Merged
Conversation
michielbdejong
approved these changes
May 25, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new chat feature using LDO and introduces extensive tests, schema definitions, and various utility functions to manage chats in Solid Pods.
- Adds the Chat class with methods for creating, updating, and deleting chats, as well as for sending and iterating messages.
- Introduces utility functions for scheduling daily triggers and handling result errors.
- Updates configuration files, shape definitions, and integration tests to support the chat functionality.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chats/ldo/test/testFiles.helper.ts | Defines a basic test resource structure for simulating chat files. |
| chats/ldo/test/integration.test.ts | Includes integration tests covering chat creation, message sending, and retrieval. |
| chats/ldo/test/configs/... | Provides sample templates and configurations for chats in Solid Pods. |
| chats/ldo/src/util/scheduleNewDayTrigger.ts | Implements a helper for triggering callbacks when a new UTC day begins. |
| chats/ldo/src/util/resultHelpers.ts | Adds functions to simplify error handling of asynchronous resource operations. |
| chats/ldo/src/Chat.ts | Contains the Chat class featuring methods for resource creation, message handling, and subscription management. |
| chats/ldo/src/.shapes/*.shex, *.ts, *.jsonld | Define the schema, context, and shape types used by chat resources. |
| chats/ldo/package.json and README.md | Update project configuration and documentation with installation and usage details. |
| chats/.gitignore and chats/README.md | Minor updates to include the new ldo chat module. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into feat/chat-ldo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat in LDO feature.