This repository was archived by the owner on Jan 31, 2023. It is now read-only.
Open
Conversation
|
@jwerle Is this change still applicable? I'm trying to reassess everything now that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with building typescript types from JSDoc comments.
heapwolf/socket#14
There are a variety of little problems left to solve though...
TypedArrayisn't a global type currently so that needs to get injected.erris not a type. Could just change these toErroroptions?: any | undefined, callback: Functionfs.ReadStreamAll in all, this seems pretty achievable, but I'm afraid this is an 80-20 effort so far and much pain and suffering lies again. haha