Fix context handling, stale test dirs, and resource leak#37
Open
jmgurney wants to merge 5 commits intosmartfile:masterfrom
Open
Fix context handling, stale test dirs, and resource leak#37jmgurney wants to merge 5 commits intosmartfile:masterfrom
jmgurney wants to merge 5 commits intosmartfile:masterfrom
Conversation
…k... don't leak file in SeekableArchive..
cabarnes
reviewed
Sep 26, 2022
|
|
||
| class MakeTempMixIn: | ||
| def setUp(self): | ||
| self.TMPDIR = tempfile.mkdtemp(suffix='.python-libarchive') |
Member
There was a problem hiding this comment.
You could use TemporaryDirectory and its member cleanup() instead to avoid importing shutil and manually deleting it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this combines a few fixes all in one, mainly I was dealing w/ a number of them and did a little bit of clean up at the same time.
ResourceWarning: unclosed filewhen running the tests.