fix KeepEverythingWithMinKWordsExtractor#2
Open
derlin wants to merge 11 commits intoslaveofcode:masterfrom
Open
fix KeepEverythingWithMinKWordsExtractor#2derlin wants to merge 11 commits intoslaveofcode:masterfrom
derlin wants to merge 11 commits intoslaveofcode:masterfrom
Conversation
- use requests instead of urllib - better encoding detection using bs4 UnicodeDammit - better python interface - remove unused data from repo
replace the deprecated impl call by a simple os.path...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the argument to the
KeepEverythingWithMinKWordsExtractorjava constructor.The problem is better explained in issue #1 ,