[Vengeance] Implement Untethered Rage free Metamorphosis#10869
Merged
ToppleTheNun merged 6 commits intosimulationcraft:midnightfrom Feb 5, 2026
Merged
[Vengeance] Implement Untethered Rage free Metamorphosis#10869ToppleTheNun merged 6 commits intosimulationcraft:midnightfrom
ToppleTheNun merged 6 commits intosimulationcraft:midnightfrom
Conversation
Complete the partial Untethered Rage implementation by adding the free Metamorphosis mechanic: - Grant a temporary Meta charge when UR buff is gained (charge-based approach matching Voidstep pattern) - UR-proc'd Meta uses 10s duration (tier 1 effect value) instead of normal 15s - Expire Seething Anger stacks on successful UR proc - When Meta is already active, ensure at least UR duration remains without shortening existing Meta (avoids extend_duration_or_trigger overextension and trigger() assertion on TICK refresh_behavior) - Add proc tracking for analysis Preserves upstream proc rate formula (0.0075 * pow(1.35, SA stacks)).
Address maintainer feedback on the UR free Meta implementation: - Add update_ready() override matching Vengeful Retreat/Voidstep pattern: expires UR buff here instead of execute() to avoid double-charge consumption (temp charge via adjust_max_charges + real charge via base_t::update_ready) - Add reset() to prevent charge desync between iterations - Use extend_duration_or_trigger() matching Demonic pattern: UR Meta extends BY 10s on top of existing Meta duration, never wastes a proc - Snapshot UR state before base_t::execute() since update_ready() runs during base execute and expires the buff before the switch statement - Remove unnecessary curly braces from switch case
ToppleTheNun
merged commit 82f4f0b
into
simulationcraft:midnight
12 of 224 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the partial Untethered Rage implementation by adding the free Metamorphosis mechanic.
Changes
adjust_max_chargesstack callback (matches Voidstep/Vengeful Retreat pattern)extend_duration_or_trigger()with 10s duration (effectN(1).base_value()), matching the Demonic talent pattern — extends BY 10s when Meta is active, triggers with 10s when Meta is downupdate_ready()override: expires UR buff to consume the temp charge without also consuming a real charge (matches VR/Voidstep)reset()override: resets cooldown max charges between iterations to prevent desyncBehavior confirmed against beta testing (credit: Meyra):
Test results (target_error=0.3, 500 iterations)
No crashes or assertion failures across 20 deterministic seeds.