Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file#63
Merged
silbinarywolf merged 1 commit intosilbinarywolf:mainfrom Feb 2, 2026
Conversation
Owner
|
Test your changes before raising a PR please. This code is failing tests at compile-time |
Contributor
Author
|
Sorry, I forgot to try to compile an example. It should work now but the github CI was cancelled for some reason. |
Owner
Its failing on Zig 0.16.X (current master), as per the Mac CI build info. (If one platform fails, it cancels the other builds) To be cross-compatible need changes like this: const cwd = if (builtin.zig_version.major == 0 and builtin.zig_version.minor <= 15)
try std.fs.cwd()
else
try std.Io.Dir.cwd()From Zig 0.16.X onwards too, most the function calls require an |
Owner
|
awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file
Fixes #62