fix failing cucumber tests (issue #106)#113
Open
bill-auger wants to merge 3 commits intosigmike:masterfrom
Open
fix failing cucumber tests (issue #106)#113bill-auger wants to merge 3 commits intosigmike:masterfrom
bill-auger wants to merge 3 commits intosigmike:masterfrom
Conversation
* Scenario: Distribute to commits not linked to a GitHub account User#recipient_label method was prefering to show identifier instead of email when nick was undefined but the test was expecting an email address - not sure which was the intended behavior but showing email to the use rather than an obtuse ID seems more reasonable
bill-auger
changed the title
several tests that filled fields on the Distribution edit form
were were passing and failing intermittently
this was most likely due to the 'auto-complete' feature
notably scenarios:
* Send distribution to multiple users
* Remove a distribution line
* Create distribution line without an amount
adding a one second delay to these steps has made all tests passing
* Given(/^I add the GitHub user "(.*?)" to the recipients$/)
* Given(/^I add the user with email "(.*?)"
through his identifier to the recipients$/)
* When(/^I add the commit "(.*?)" to the recipients$/)
Author
|
several tests that filled fields on the Distribution edit form were were passing and failing intermittently - this was most likely due to the 'auto-complete' feature notably scenarios:
adding a one second delay to these steps has made all tests passing
|
these were intended to be included in the previous commit
Author
|
the additions to the last commit were intended to be included in the previous commit these steps were not the source of any test failures but if the autocomplete feature was the cause of the failures addressed by this pull request, then the potential exists for these to be problematic - as these failures were intermittent and therefore insideous its best to guard against them the sibling 'email' field does not implement the autocomplete feature so i assume no wait is needed for its related step |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User#recipient_label method was prefering to show identifier instead of email when nick was undefined but the test was expecting an email address - not sure which was the intended behavior but showing email to the user rather than an obtuse ID seems more reasonable
is it possible this could be a private email address ? then perhaps to modify the test instead to expexct an ID - the original implementation would still show the email address however in cases where no nick nor ID is defined if such a state is possible