Conversation
|
Hey @lhr0909, thank you for the time and effort you put into this contribution! While at it, I also upgraded the Swift version to 6.2, and added your iOS 16 contribution again. So I will abandon this PR but don't be worried, you are of course credited (see 7fefafb). Thanks again for this PR. Have you used it in any projects? I would love to hear the applications you have. |
|
Thank you @sgade ! We are in the process of integrating into our iOS App. So far we are still trying out what SwiftUI elements can be used to render PDF. But after this change we are able to integrate. We are still on Swift 5 with our app, I am curious if it will be an issue when the package is upgraded to Swift 6? |
|
Interesting. If you use the Swift 6 compiler, the language mode of each package can be different. Let me know if there needs to be a better Swift 5 compatibility story. |
We are not yet migrated to Swift 6 (soon!), and would be great if we can keep the swift version at 5 (for a minor) then upgrade to 6 so we can properly take this as upstream dependency. Once we are ready to move to Swift 6 we will upgrade. Thank you! |
|
Since I didn't tag a release I used this to force-push (!) and tag version 1.1.0 which includes iOS 16 support. Swift 6.2 is on main still, untagged until the pipeline starts working (hopefully soon). |
Thank you! This will work well for us! iOS 16+ makes the library working on iOS apps without issues so far. Once our implementation is done and stable, we will move our dependency to take v1.1.0 of this repo. Thanks again for the prompt response! Cheers! |
I see the package swift is not enabling iOS support, so I am sending a PR to enable it. I am using the lowest iOS version possible.