Added typing information and fixed bug in sentence, paragraph, and text functions#2
Open
Ahsoka wants to merge 5 commits intosfischer13:masterfrom
Open
Added typing information and fixed bug in sentence, paragraph, and text functions#2Ahsoka wants to merge 5 commits intosfischer13:masterfrom
sentence, paragraph, and text functions#2Ahsoka wants to merge 5 commits intosfischer13:masterfrom
Conversation
I believe `args` and `kwargs` are meant to be passed into the `__init__` method and not the `sentence`, `paragraph`, or `text` methods as passing any arguements there would cause a `TypeError`
(before this only supported Python 3.9 and up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will make this code only compatible with Python 3.5 and higher. If you want to preserve backwards compatibility with older versions of Python, only include the first two commits of this pull request, 7175063 and 592a955, in versions that you wish to preserve backwards compatibility.