Open
Conversation
develpr
changed the title
Author
|
Any chance this would be reviewed at some point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #93 involves adding support for OpenWhisk. There may be a number of issues changes required to fully support OpenWhisk. This is a bare minimum I believe, because without this change an exception will always be thrown for OpenWhisk
sequencesif they do not contain a handler.In this pull request I filter out functions that have a sequence defined for them only if they also do not have a handler supplied. We essentially "skip" over the TypeScript plugin handling logic in this case and allow other plugins / processes to act accordingly for the particular function.
I also updated the
ServerlessOptionsmodel to allow for an optionalsequenceto be defined on the class.