This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Added ASG template, explicit types in module arguments#81
Open
kchugalinskiy wants to merge 12 commits intosegmentio:masterfrom
Open
Added ASG template, explicit types in module arguments#81kchugalinskiy wants to merge 12 commits intosegmentio:masterfrom
kchugalinskiy wants to merge 12 commits intosegmentio:masterfrom
Conversation
added 12 commits
January 23, 2017 18:04
Contributor
|
Is the purpose to be able to manage an autoscaling group without having an ECS cluster? |
Author
|
@achille-roussel yep, that's the reason. It seems to be reasonable. |
Contributor
|
I'm OK adding such a module but this PR has many backward incompatible changes, do you think you could make a PR that only focuses on adding the asg module? |
Author
|
@achille-roussel yeah, surely! Just give me a weekeend :-) |
|
@kchugalinskiy how's the weekend going so far? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.