This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Move ingress/egress to aws_security_group_rule in rds#119
Open
thattommyhall wants to merge 1 commit intosegmentio:masterfrom
Open
Move ingress/egress to aws_security_group_rule in rds#119thattommyhall wants to merge 1 commit intosegmentio:masterfrom
thattommyhall wants to merge 1 commit intosegmentio:masterfrom
Conversation
When I make an RDS instance, it kept saying it needed to change stuff. This is also best practice from what I can tell (if users of the module need to add rules to the SG also)
Contributor
|
There's a risk of this causing issues when being applied to an existing infrastructure isn't it? Could you show the plan that result from this change on an existing RDS cluster? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I make an RDS instance, it kept saying it needed to change stuff.
This is also best practice from what I can tell (if users of the module
need to add rules to the SG also)