Skip to content

Local adapter gracefully fails if file doesnt exist #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deluxetom merged 3 commits into from
Feb 9, 2026
Merged

Local adapter gracefully fails if file doesnt exist #21

deluxetom merged 3 commits into from
Feb 9, 2026

Conversation

@deluxetom
Copy link
Collaborator

@deluxetom deluxetom commented Feb 9, 2026

I also added .gitattributes for all packages, to avoid this issue:

PHP Fatal error:  Cannot redeclare class Secretary\Tests\ManagerTest (previously declared in ~/secretary/php/src/Core/Tests/ManagerTest.php:22) in ~/secretary/php/src/Bundle/SecretaryBundle/vendor/secretary/core/Tests/ManagerTest.php on line 24
Stack trace:
#0 ~/secretary/php/vendor/phpunit/phpunit/src/Runner/TestSuiteLoader.php(116): require_once()

@deluxetom deluxetom merged commit 9a355a9 into master Feb 9, 2026
66 of 68 checks passed
@deluxetom deluxetom deleted the local-adapter-gracefully-fail branch February 9, 2026 17:32
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptiklemur cryptiklemur Awaiting requested review from cryptiklemur

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ChainAdapter should gracefully fail if the file is missing

1 participant

@deluxetom