Exclude Glob doesn't exclude#9
Open
ninjapanzer wants to merge 2 commits intoscruplelesswizard:mainfrom
Open
Conversation
ninjapanzer
force-pushed
the
pks/exclude-glob/fix_exclude_glob
branch
from
65a0e12 to
9dfc57c
Compare
scruplelesswizard
approved these changes
Feb 14, 2025
|
Any chance of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whats going on?
Well I noticed when I use glob and exclude-glob while the exclude glob looks correct the tests are not excluded
What I expect?
When the exclude a glob the tests will be excluded
What have I done
I wrote a test to prove that with glob and exclude-glob the excluded test is still present in the expected test suites.
Fixes #8
@scruplelesswizard Got this working on my fork since tests require approval here ninjapanzer#1