Adding authentication to user end points. List, GetUser, Count and Delete#166
Open
ShanuWije wants to merge 3 commits intoscorelab:masterfrom
Open
Adding authentication to user end points. List, GetUser, Count and Delete#166ShanuWije wants to merge 3 commits intoscorelab:masterfrom
ShanuWije wants to merge 3 commits intoscorelab:masterfrom
Conversation
As part of the master of information security bug bounty assignment have identified that these endpoints needs to be secured. Otherwise any one can list the users and get the count without login in
ShanuWije
changed the title
ShanuWije
commented
May 15, 2021
Author
ShanuWije
left a comment
ShanuWije
left a comment
There was a problem hiding this comment.
Needs to have a proper validation on the delete user end point. Otherwise anyone can delete any user, even a normal user can delete a admin user account
…sed to enumerate all the users in the database without login in
ShanuWije
changed the title
ShanuWije
changed the title
ShanuWije
changed the title
ShanuWije
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the master of information security bug bounty assignment have identified that these endpoints needs to be secured. Otherwise any one can view the list of users and get the count without even login in
Description
As part of the master of information security bug bounty assignment have identified that these endpoints needs to be secured. Otherwise any one can list the users and get the count without login in
Fixes # (issue)
Type of change
Security fix