You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.05%. Comparing base (6ab0c12) to head (33b2e42). ⚠️ Report is 4 commits behind head on main.
Only one comment not related to the changes in the MR: I cannot reliably build the 'tests' target with the current project setup: If I first follow the instructions to build the tests target (conan v2, CMake > 3.19) everything works. However, if I first follow the instructions for building the ScipPP target and subsequently want to build the tests target, the error "No rule to make target tests" is thrown. This can be fixed by using tc.cache_variables["BUILD_TESTS"] instead of tc.variables["BUILD_TESTS"] in the conanfile.py. Same holds true for other variables set in the conanfile.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many methods were already marked as
const. The memberm_lastReturnCodeis always indirectly modified viam_scipCallWrapper.Now the member
m_lastReturnCodeis marked mutable and all methods that can be const are now const.