Skip to content

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Feb 6, 2026

Issue: CLDSRV-846

@bert-e
Copy link
Contributor

bert-e commented Feb 6, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Feb 6, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 6, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov
Copy link

codecov bot commented Feb 6, 2026

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
8120 6 8114 0
View the full list of 6 ❄️ flaky test(s)
"after each" hook for "should batch delete 1000 objects quietly"::Multi-Object Versioning Delete Success With default signature "after each" hook for "should batch delete 1000 objects quietly"

Flake rate in main: 100.00% (Passed 0 times, Failed 87 times)

Stack Traces | 0.09s run time
The bucket you tried to delete is not empty.
"after each" hook for "should put an object and set the acl via query param"::PUT object With v4 signature "after each" hook for "should put an object and set the acl via query param"

Flake rate in main: 100.00% (Passed 0 times, Failed 18 times)

Stack Traces | 0.012s run time
Expected values to be strictly equal:
+ actual - expected

+ '404 NOT FOUND'
- '200 OK'
"after each" hook for "should put an object and set the acl via query param"::PUT object With v4 signature "after each" hook for "should put an object and set the acl via query param"

Flake rate in main: 100.00% (Passed 0 times, Failed 18 times)

Stack Traces | 0.012s run time
done() called multiple times in hook <PUT object With v4 signature "after each" hook for "should put an object and set the acl via query param"> of file .../test/object/put.js
"after each" hook for "should put object with valid object lock retention date and mode when object lock is enabled on the bucket"::PUT object with object lock With default signature "after each" hook for "should put object with valid object lock retention date and mode when object lock is enabled on the bucket"

Flake rate in main: 100.00% (Passed 0 times, Failed 18 times)

Stack Traces | 0.003s run time
The specified bucket does not exist.
"before each" hook for "should batch delete 1000 objects quietly"::Multi-Object Versioning Delete Success With default signature "before each" hook for "should batch delete 1000 objects quietly"

Flake rate in main: 100.00% (Passed 0 times, Failed 87 times)

Stack Traces | 0.023s run time
socket hang up
"before each" hook for "should put object with valid object lock retention date and mode when object lock is enabled on the bucket"::PUT object with object lock With default signature "before each" hook for "should put object with valid object lock retention date and mode when object lock is enabled on the bucket"

Flake rate in main: 100.00% (Passed 0 times, Failed 18 times)

Stack Traces | 0.006s run time
The requested bucket name is not available. The bucket namespace is shared by all users of the system. Please select a different name and try again.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-846-migrate-bucket-logging-tests branch from 4d8dec1 to ddec5d3 Compare February 6, 2026 14:02
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-846-migrate-bucket-logging-tests branch from ddec5d3 to c4cc857 Compare February 6, 2026 14:04
@benzekrimaha benzekrimaha marked this pull request as ready for review February 6, 2026 14:04
@benzekrimaha benzekrimaha requested review from a team, DarkIsDude and delthas February 6, 2026 14:04
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-846-migrate-bucket-logging-tests branch from 45ea020 to 2aac5d4 Compare February 6, 2026 14:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have test for that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is actually used for cmd line commands , when I checked we indeed don't have tests for it as not really needed

@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.3

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Queue build failed

The corresponding build for the queue failed:

  • Checkout the status page.
  • Identify the failing build and review the logs.
  • If no issue is found, re-run the build.
  • If an issue is identified, checkout the steps below to remove
    the pull request from the queue for further analysis and maybe rebase/merge.
Remove the pull request from the queue
  • Add a /wait comment on this pull request.
  • Click on login on the status page.
  • Go into the manage page.
  • Find the option called Rebuild the queue and click on it.
    Bert-E will loop again on all pull requests to put the valid ones
    in the queue again, while skipping the one with the /wait comment.
  • Wait for the new queue to merge, then merge/rebase your pull request
    with the latest changes to then work on a proper fix.
  • Once the issue is fixed, delete the /wait comment and
    follow the usual process to merge the pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.3

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

Please check the status of the associated issue CLDSRV-846.

Goodbye benzekrimaha.

@bert-e bert-e merged commit 7266dce into development/9.3 Feb 9, 2026
70 of 73 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-846-migrate-bucket-logging-tests branch February 9, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants