🎨 format on bucketGet and objectGetLegalHold for async/await

[DarkIsDude]

Issue: CLDSRV-823

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

[bert-e]

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Conflict

There is a conflict between your branch feature/CLDSRV-823/formatting-only and the
destination branch development/9.3.

Please resolve the conflict on the feature branch (feature/CLDSRV-823/formatting-only).

git fetch && \
git checkout origin/feature/CLDSRV-823/formatting-only && \
git merge origin/development/9.3

Resolve merge conflicts and commit

git push origin HEAD:feature/CLDSRV-823/formatting-only

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
8105	1	8104	0

View the top 1 failed test(s) by shortest run time

"before all" hook for "should delete a object uploaded in parts successfully"::DELETE object With default signature with multipart upload "before all" hook for "should delete a object uploaded in parts successfully"

Stack Traces | 0.172s run time

socket hang up

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[maeldonn]

What the goal of this PR ? We should wait the validation of the prettier configuration before starting formatting files. It can lead to unnecessary conflicts...

[DarkIsDude]

What the goal of this PR ? We should wait the validation of the prettier configuration before starting formatting files. It can lead to unnecessary conflicts...

You have the reason of this PR here #6045 (comment). Prettier can fix some stuff but not all of them and I hope that we'll not do a one shot with prettier but first add prettier and will validate only file that are in the diff and after some months migrate remaining one, because if we do that, we'll have conflicts on all PR. Also prettier will not be able to fix everything and we'll always need to do some manual work.

[DarkIsDude]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/9.3

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

Queue build failed

The corresponding build for the queue failed:

• Checkout the status page.
• Identify the failing build and review the logs.
• If no issue is found, re-run the build.
• If an issue is identified, checkout the steps below to remove
  the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

• Add a /wait comment on this pull request.
• Click on login on the status page.
• Go into the manage page.
• Find the option called Rebuild the queue and click on it.
  Bert-E will loop again on all pull requests to put the valid ones
  in the queue again, while skipping the one with the /wait comment.
• Wait for the new queue to merge, then merge/rebase your pull request
  with the latest changes to then work on a proper fix.
• Once the issue is fixed, delete the /wait comment and
  follow the usual process to merge the pull request.

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.3

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2

Please check the status of the associated issue CLDSRV-823.

Goodbye darkisdude.