aarch64: Guard RCPC3 intrinsics with target_has_atomic = "64"#2020
Open
Snehal-Reddy wants to merge 1 commit intorust-lang:mainfrom
Open
aarch64: Guard RCPC3 intrinsics with target_has_atomic = "64"#2020Snehal-Reddy wants to merge 1 commit intorust-lang:mainfrom
Snehal-Reddy wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
The `vldap1` and `vstl1` RCPC3 intrinsics introduced in standard library unconditionally use `AtomicI64`. This breaks builds on target that do not support 64-bit atomics, such as `aarch64-unknown-none` with `max-atomic-width` set to 0. This commit adds a `#[cfg(target_has_atomic = "64")]` guard to these intrinsics
sayantn
approved these changes
Feb 8, 2026
Contributor
sayantn
left a comment
sayantn
left a comment
There was a problem hiding this comment.
lgtm, waiting to confirm that this is not a breaking change (just to be safe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vldap1andvstl1RCPC3 intrinsics introduced in standard library unconditionally useAtomicI64. This breaks builds on target that do not support 64-bit atomics, such asaarch64-unknown-nonewithmax-atomic-widthset to 0.This commit adds a
#[cfg(target_has_atomic = "64")]guard to these intrinsics.fixes #2019
Open to other suggestions as well!