-
Notifications
You must be signed in to change notification settings - Fork 1k
docs(changelog): update for v1.29.0 stable release #4697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| * chore(deps): lock file maintenance by @renovate[bot] in https://github.com/rust-lang/rustup/pull/4630 | ||
| * feat: Added xonsh shell support by @anki-code in https://github.com/rust-lang/rustup/pull/4626 | ||
| * download: statically bundle relevant trust anchors by @djc in https://github.com/rust-lang/rustup/pull/4631 | ||
| * test(static-roots): refine `store_static_roots()` by @rami3l in https://github.com/rust-lang/rustup/pull/4634 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of pre-existing, but maybe drop a bunch of the chore and test PRs from this list, since they don't affect the published product?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djc I see what you mean and I can grep them away immediately, but there hasn't been a very effective way of filtering out all those lines unless we stick to semantic commit PR titles: there has been a lot of them actually up to this point, and it's not very practical to open each of them and see what it does 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking of which, I would like to enforce semantic commit PR titles in the future so that we can do something like https://github.com/googleapis/release-please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it's fine to make a first pass based on the obvious suspects (all of the PRs authored by dependabot), anything that did use the a test or ci prefix...
|
We should try to land before release |
Warning
This PR is waiting on #4696.
This is the 1st PR for the
1.29.0stable release according to our release process.This PR will also close #4652 via a
dev-guideupdate.Checklist
Bump version in the manifest.(Not required, already done in dist: bumprustupversion to v1.29.0 #4513.)