Open
Conversation
per https://toml.io/en/v1.0.0#inline-table, `No newlines are allowed between the curly braces unless they are valid within a value`. Partially fixes rust-in-action#77 (there's also the "unresolved import `smoltcp::phy::TapInterface`" issue).
Author
|
the question is what needs to happen to get this PR merged 😄 @timClicks - are you still looking at this repo? |
Contributor
|
Yes I am! Sorry that I'm not very active.
I don't accept any PRs for copyright reasons.
…On Thu, 12 Jan 2023 at 09:53, Dmitry Savintsev ***@***.***> wrote:
the question is what needs to happen to get this PR merged 😄
@timClicks <https://github.com/timClicks> - are you still looking at this
repo?
—
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGZ4IWCJ3UDQ3WUJXZYXDWR4MVDANCNFSM6AAAAAAR5R2SSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@timClicks Perhaps you could at least put a note (near the top) of the README file that says "sorry I don't accept PRs for copyright reasons". Because there are ~18 months of PRs (including several duplicates) that people have created, trying to help, because they didn't know you weren't going to accept them. (Inexplicably GitHub still doesn't allow disabling PRs in a repo while leaving issues enabled :-( ) Ewen |
Contributor
|
I understand the frustration. I'll look into adding a note on the README. Leaving the PRs open was intended to make it less likely that there will be duplicate effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per https://toml.io/en/v1.0.0#inline-table,
No newlines are allowed between the curly braces unless they are valid within a value.Fixes #77.