ch8: wraperror2: remove map_err() call#100
Open
ewenmcneill wants to merge 1 commit intorust-in-action:1st-editionfrom
Open
ch8: wraperror2: remove map_err() call#100ewenmcneill wants to merge 1 commit intorust-in-action:1st-editionfrom
ewenmcneill wants to merge 1 commit intorust-in-action:1st-editionfrom
Conversation
To match the book text (Listing 8.15, which is supposed to match ch8/misc/wraperror2.rs), actually remove the map_err() calls that are not supposed to be needed once the std::convert::From trait is implemented for the wrapped types.
ewenmcneill
force-pushed
the
ch8-wraperror2-match-book-text
branch
from
4b9d766 to
b7d225a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match the book text (Listing 8.15, which is supposed to match
ch8/misc/wraperror2.rs), actually remove themap_err()calls that are not supposed to be needed once thestd::convert::Fromtrait is implemented for the wrapped types.Without this change, the difference between
wraperror.rsandwraperror2.rsis not particularly obvious, as thestd::convert::Fromtraits are unnecessary. (The code does compile without this change, because the in repository implementation is basically the same asch8/misc/wraperror.rs.)ETA: Force pushed a replacement to fix typo in commit comment that I noticed while editing the PR text.