Determine rustc version and add it to the report#81
Determine rustc version and add it to the report#81TheTechRobo wants to merge 7 commits intorust-cli:masterfrom
Conversation
|
Cargo also sets the |
Did not know that! I'll update that right now. |
|
@bjorn3 - getting this issue: I'm on nightly. |
|
You should use |
|
@bjorn3 - All done. |
bjorn3
left a comment
There was a problem hiding this comment.
LGTM apart from one nit. Do note that I am not a member of this org, so you will have to wait on someone who is to review and merge.
|
Should I rebase this PR, or are the maintainers fine with 7 (maybe more later if there's more review) commits? |
|
It probably won't hurt to squash. No idea what the maintainers prefer though. |
|
I'll probably have time to rebase this on Sunday. |
This is a 🙋 feature.
Checklist
Context
Fixes #31
Semver Changes
Major release - it changes the
Reportstruct. I don't think 2.0 is released yet, so that would fit perfectly!I have very little experience contributing to Rust crates, so if I made any mistakes, let me know!