-
-
Notifications
You must be signed in to change notification settings - Fork 227
GHSA SYNC: 2 new advisories; 3 modified advisories #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasnow
wants to merge
2
commits into
rubysec:master
Choose a base branch
from
jasnow:ghsa-syncbot-2026-02-08-07_32_26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−8
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| --- | ||
| gem: spree_storefront | ||
| cve: 2026-25757 | ||
| ghsa: p6pv-q7rc-g4h9 | ||
| url: https://github.com/spree/spree/security/advisories/GHSA-p6pv-q7rc-g4h9 | ||
| title: Unauthenticated Spree Commerce users can view completed | ||
| guest orders by Order ID | ||
| date: 2026-02-05 | ||
| description: | | ||
| ### Unauthenticated users can view completed guest orders by Order ID (`GHSL-2026-029`) | ||
|
|
||
| The `OrdersController#show` action permits viewing completed | ||
| guest orders by order number alone, without requiring the | ||
| associated order token. | ||
|
|
||
| Order lookup without enforcing token requirement in | ||
| [`OrdersController#show`](https://github.com/spree/spree/blob/1341623f2ae92685cdbe232885bf5808fc8f9ca8/storefront/app/controllers/spree/orders_controller.rb#L14): | ||
|
|
||
| ```ruby | ||
| @order = complete_order_finder.new(number: params[:id], | ||
| token: params[:token], store: current_store).execute.first | ||
| ``` | ||
|
|
||
| Authorization bypass for guest orders in [`authorize_access`](https://github.com/spree/spree/blob/1341623f2ae92685cdbe232885bf5808fc8f9ca8/storefront/app/controllers/spree/orders_controller.rb#L51C1-L55C8): | ||
|
|
||
| ```ruby | ||
| def authorize_access | ||
| return true if @order.user_id.nil? | ||
|
|
||
| @order.user == try_spree_current_user | ||
| end | ||
| ``` | ||
|
|
||
| If the attacker is in possession of a leaked Order ID, they might | ||
| look it up directly via this API. | ||
| Alternatively, brute forcing all or parts of the possible Order IDs | ||
| might be feasible for an attacker. (The Order IDs themselves are | ||
| [securely generated](https://github.com/spree/spree/blob/a878eb4a782ce0445d218ea86fb12075b0e3d7cc/core/lib/spree/core/number_generator.rb#L45), | ||
| but with relatively low entropy: by default an order ID has a length | ||
| of 9 and a base of 10, that would require an attacker to perform | ||
| 1 billion requests to gather all guest orders. (At an assumed | ||
| constant rate of 100 requests per second it would take 115 days.) | ||
|
|
||
| #### Impact | ||
|
|
||
| This issue may lead to disclosure of PII of guest users | ||
| (including names, addresses and phone numbers). | ||
|
|
||
| #### CWEs | ||
|
|
||
| - CWE-639: Authorization Bypass Through User-Controlled Key | ||
|
|
||
| ### Credit | ||
|
|
||
| This issue was discovered with the [GitHub Security Lab Taskflow Agent](https://github.com/GitHubSecurityLab/seclab-taskflow-agent) | ||
| and manually verified by GHSL team members | ||
| [@p- (Peter Stöckli)](https://github.com/p-) and | ||
| [@m-y-mo (Man Yue Mo)](https://github.com/m-y-mo). | ||
|
|
||
| ### Disclosure Policy | ||
|
|
||
| This report is subject to a 90-day disclosure deadline, as | ||
| described in more detail in our [coordinated disclosure policy](https://securitylab.github.com/advisories#policy). | ||
| cvss_v4: 7.7 | ||
| patched_versions: | ||
| - "~> 5.0.8" | ||
| - "~> 5.1.10" | ||
| - "~> 5.2.7" | ||
| - ">= 5.3.2" | ||
| related: | ||
| url: | ||
| - https://nvd.nist.gov/vuln/detail/CVE-2026-25757 | ||
| - https://github.com/spree/spree/security/advisories/GHSA-p6pv-q7rc-g4h9 | ||
| - https://github.com/spree/spree/commit/3e00be64c128ef4bd4b99731f0c3ab469509cfab | ||
| - https://github.com/spree/spree/commit/6b32ed7d474aa55fa441990e6aa39740152aa1be | ||
| - https://github.com/spree/spree/commit/6f6b8a7a28a8bff24a6e20eab04b4bbbdf39384d | ||
| - https://github.com/spree/spree/commit/ea4a5db590ca753dbc986f2a4e818d9e0edfb1ad | ||
| - https://github.com/spree/spree/blob/1341623f2ae92685cdbe232885bf5808fc8f9ca8/storefront/app/controllers/spree/orders_controller.rb#L14 | ||
| - https://github.com/spree/spree/blob/1341623f2ae92685cdbe232885bf5808fc8f9ca8/storefront/app/controllers/spree/orders_controller.rb#L51C1-L55C8 | ||
| - https://github.com/spree/spree/blob/a878eb4a782ce0445d218ea86fb12075b0e3d7cc/core/lib/spree/core/number_generator.rb#L45 | ||
| - https://advisories.gitlab.com/pkg/gem/spree_storefront/CVE-2026-25757 | ||
| - https://github.com/advisories/GHSA-p6pv-q7rc-g4h9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that
gems/spree_storefront/CVE-2026-25757.ymlhas been added, we can deletegems/spree_storefront/GHSA-p6pv-q7rc-g4h9.ymlas they reference the same GHSA.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge PR#585 and I would have catch this.