use correct logger while migration#215
Closed
tsechingho wants to merge 1 commit intorubycas:masterfrom
Closed
Conversation
|
Hi, thanks for contribution Actually I do not see any reason why we would like to keep that task but maybe there is some black magic behind it. But anyway, when you are running the server, migration will be done in But since we already have it we will maintain that code of course there is just question if we need to set the I prepared a new pull request (#218) based on your code which I think make much more sens in that case. Take a look and give some feedback if this will do the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should use $LOG to assign logger, since the CASServer::Model::Ticket module is no more has
loggermethod/variable.It also needs to require 'casserver/authenticators/base' to make migrate work.
I also fix the rake description.