Conversation
The Aliki TOC is generated by JavaScript that scans h1/h2/h3 elements with IDs. Section title h2 elements had no ID, so they were invisible to the TOC. Meanwhile, h3 IDs like "constants" and "public-instance-methods" were duplicated across sections. Prefix all heading IDs with the section's aref to make them unique. Move the section ID from the <section> element to the <h2> so the TOC picks it up naturally. Fixes #1598
Collaborator
|
🚀 Preview deployment available at: https://01b9805e.rdoc-6cd.pages.dev (commit: 156cd5f) |
Contributor
|
Do you want to keep sections in the left sidebar? It feels redundant with the TOC (which itself is also not present in the sidebar) |
Member
Author
|
ToC is currently hidden on mobile. So if we removed it from sidebar, the sections info would just be unavailable on mobile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aliki TOC is generated by JavaScript that scans h1/h2/h3 elements with IDs. Section title h2 elements had no ID, so they were invisible to the TOC. Meanwhile, h3 IDs like "constants" and "public-instance-methods" were duplicated across sections.
Prefix all heading IDs with the section's aref to make them unique. Move the section ID from the
<section>element to the<h2>so the TOC picks it up naturally.Fixes #1598