Raise Net::OpenTimeout when TCPSocket.open raises IO::TimeoutError.#263
Merged
hsbt merged 1 commit intoruby:masterfrom Dec 17, 2025
Merged
Conversation
shioimm
force-pushed
the
catch-ETIMEDOUT-or-IOTimeoutError
branch
5 times, most recently
from
da2aa1e to
c87e869
Compare
…or`. With the changes in ruby/ruby#15602, `TCPSocket.open` now raises `IO::TimeoutError` when a user-specified timeout occurs. This change updates #connect to handle this case accordingly.
shioimm
force-pushed
the
catch-ETIMEDOUT-or-IOTimeoutError
branch
from
c87e869 to
f64109e
Compare
hsbt
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in ruby/ruby#15602,
TCPSocket.opennow raisesIO::TimeoutErrorwhen a user-specified timeout occurs. This change updates #connect to handle this case accordingly.