Conversation
Author
|
is this valid? @hsbt |
mame
reviewed
Jun 10, 2025
mame
reviewed
Jun 10, 2025
Member
mame
left a comment
There was a problem hiding this comment.
Can you confirm if this patch works well for rdoc? I am not sure if rdoc can handle these aliases as class methods but not instance methods.
Author
|
@mame created the requested tests it looks like the expected behaviour to me |
Author
|
sorry for this ping @mame |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Basically, I hated how I had to write Base64.encode64, it felt so redundant, so I created aliases for every method of this library, to allow for a more simple "Base64.encode"
I also added tests for what I wrote, and "gemspec" to Gemfile to allow bin/console to load the gem you are working on, and not the one installed in the system