Removed unused composeFiles from client.go #275
+26
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `composeFiles` variable from `compose()` and its use in all the calling functions. I liked how the CLI used a directory structure for instrumenting the docker-compose files, and knew that Compose itself didn't support that, so was curious what it was doing under the hood. In looking over the code, I saw that the `composeFiles` variable was never used, so figured I'd remove it and clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
composeFilesvariable fromcompose()and its use in all the calling functions.I liked how the CLI used a directory structure for instrumenting the docker-compose files, and knew that Compose itself didn't support that, so was curious what it was doing under the hood. In looking over the code, I saw that the
composeFilesvariable was never used, so figured I'd remove it and clean it up.