Feature/transactions (Depends on PR #37)#38
Merged
r-jarvis merged 2 commits into3.0-previewfrom Jun 30, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0-preview #38 +/- ##
===============================================
+ Coverage 84.26% 86.57% +2.31%
===============================================
Files 35 69 +34
Lines 2936 9627 +6691
===============================================
+ Hits 2474 8335 +5861
- Misses 462 1292 +830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feature/transactions
…before exiting withTransaction feature/transactions
15272b6 to
ab6b1d9
Compare
r-jarvis
reviewed
Jun 24, 2025
r-jarvis
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #37
The main thing I'm not 100% happy with is that
transactionAuthoron endpoints is ignored within a transaction. I don't see a reasonable way around it.