chore: maintained Node.js (14+) required#1923
Open
rektide wants to merge 4 commits intorestify:masterfrom
Open
chore: maintained Node.js (14+) required#1923rektide wants to merge 4 commits intorestify:masterfrom
rektide wants to merge 4 commits intorestify:masterfrom
Conversation
3 tasks
rektide
changed the title
sternam
approved these changes
Nov 9, 2022
3 tasks
acommodari
reviewed
Nov 28, 2022
| | 16.x | **Yes** | Active LTS | | ||
| | 14.x | **Yes** | Maintenance LTS | | ||
| | 12.x | **No** | Use restify v8.x, team will backport critical issues only | | ||
| | 12.x | **No** | Use restify v8.x, team will backport critical issues only | |
There was a problem hiding this comment.
Duplicate line? unless you meant to say 10.x?
sternam
suggested changes
Nov 28, 2022
| | 16.x | **Yes** | Active LTS | | ||
| | 14.x | **Yes** | Maintenance LTS | | ||
| | 12.x | **No** | Use restify v8.x, team will backport critical issues only | | ||
| | 12.x | **No** | Use restify v8.x, team will backport critical issues only | |
There was a problem hiding this comment.
Suggested change
| | 12.x | **No** | Use restify v8.x, team will backport critical issues only | | |
| | 10.x | **No** | Use restify v8.x, team will backport critical issues only | |
BREAKING CHANGE: drops support for node 10 and node 12 and updates lint rules
rektide
force-pushed
the
node-14
branch
2 times, most recently
from
16b8fbd to
82ec9c8
Compare
sternam
approved these changes
Jan 9, 2023
ghermeto
suggested changes
Feb 15, 2023
| The MIT License (MIT) | ||
|
|
||
| Copyright (c) 2018 restify | ||
| Copyright (c) 2023 restify |
Contributor
There was a problem hiding this comment.
please remove this change
| "coveralls": "^3.0.3", | ||
| "documentation": "^11.0.0", | ||
| "eslint": "^5.16.0", | ||
| "eslint": "^6.8.0", |
Contributor
There was a problem hiding this comment.
Please don't make an unrelated change unless strictly necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
Changes
eslintto support ecmascriptVersion 2020.Request.prototype.closedpatch clashes with new Readable.closed getter #1888 for v18.