fall back to web when maDisplayTool is not a sibling #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generate-arena-config.js script assumes, that maDisplayTools lives in a sibling folder. If this isn't the case, this new version downloads the most recent version from github. Possibly this could be the default? If I run this right now, I get one more arena: G6_3x16_full
Contributor
|
this change brings in a hardcoded branch name (feature/g6-tools)...I was planning to merge this stuff to main (in that repo) by the weekend, so maybe it's better to wait a few days and, as suggested, use the maDisplayTool as the default at that time? |
Member
Author
|
Yes, that would be better than the current suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generate-arena-config.js script assumes, that maDisplayTools lives in a sibling folder. If this isn't the case, this new version downloads the most recent version from github. Possibly this could be the default?
If I run this right now, I get one more arena: G6_3x16_full