Skip to content

Feature/auto commit 1770189937#1646

Open
Learnerbypassion wants to merge 3 commits intoreactplay:mainfrom
Learnerbypassion:feature/auto-commit-1770189937
Open

Feature/auto commit 1770189937#1646
Learnerbypassion wants to merge 3 commits intoreactplay:mainfrom
Learnerbypassion:feature/auto-commit-1770189937

Conversation

@Learnerbypassion
Copy link

@Learnerbypassion Learnerbypassion commented Feb 4, 2026

Before creating this PR, please confirm the following:


First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for reactplayio failed. Why did it fail? →

Name Link
🔨 Latest commit 9855fce
🔍 Latest deploy log https://app.netlify.com/projects/reactplayio/deploys/6985a708ec20e300087c9608

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagnosis

  • The build fails because ESLint reports formatting violations in src/plays/soham-bhattacharya/SohamBhattacharya.js, causing react-scripts build to exit with status 2. See line 988-line 1000.

Solution

  • Update the file to satisfy the lint rules. You can run the project’s formatter (e.g., pnpm lint --fix or pnpm format if available) or edit the file manually:
    pnpm lint --fix
    or manually remove the extra indentation, add the required spaces, and insert the blank lines noted at lines 49, 65-66, 76, 89, 93, and 112.
  • Commit the corrected file and redeploy.

The relevant error logs are:

Line 0: build-image version: 78d0fcff90a66ed4048cfb3252450561538f796a (noble-new-builds)
Line 1: buildbot version: cbb330566fbc2c88d277ceda93fc833ecdc87883
Line 2: Fetching cached dependencies
Line 3: Failed to fetch cache, continuing with build
Line 4: Starting to prepare the repo for build
Line 5: No cached dependencies found. Cloning fresh repo
Line 6: git clone --filter=blob:none https://github.com/reactplay/react-play
Line 7: Preparing Git Reference pull/1646/head
Line 8: Starting to install dependencies
Line 9: mise �[36m~/.config/mise/config.toml�[0m tools: �[34mpython�[0m@3.14.2
Line 10: mise �[36m~/.config/mise/config.toml�[0m tools: �[34mruby�[0m@3.4.8
Line 11: mise �[36m~/.config/mise/config.toml�[0m tools: �[34mgo�[0m@1.25.6
Line 12: v18.20.8 is already installed.
Line 13: Now using node v18.20.8 (npm v10.8.2)
Line 37: Progress: resolved 335, reused 0, downloaded 315, added 0
Line 38: Progress: resolved 390, reused 0, downloaded 366, added 0
Line 39: Progress: resolved 521, reused 0, downloaded 485, added 0
Line 40: Progress: resolved 705, reused 0, downloaded 645, added 0
Line 41: Progress: resolved 725, reused 0, downloaded 661, added 0
Line 42: Progress: resolved 822, reused 0, downloaded 738, added 0
Line 43: Progress: resolved 1044, reused 0, downloaded 942, added 0
Line 44: Progress: resolved 1289, reused 0, downloaded 1164, added 0
Line 45: Progress: resolved 1506, reused 0, downloaded 1382, added 0
Line 46: Progress: resolved 1795, reused 0, downloaded 1675, added 0
Line 47:  WARN  33 deprecated subdependencies found: @babel/plugin-proposal-class-properties@7.18.6, @babel/plugin-proposal-nullish-coale
Line 48: Packages: +1760
Line 49: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Line 50: Progress: resolved 1795, reused 0, downloaded 1763, added 695
Line 51: Progress: resolved 1795, reused 0, downloaded 1763, added 1759
Line 52: Progress: resolved 1795, reused 0, downloaded 1763, added 1760, done
Line 53: > react-play@1.0.0 prepare /opt/build/repo
Line 54: > husky install
Line 55: husky - Git hooks installed
Line 56:  WARN  Issues with peer dependencies found
Line 57: .
Line 104: + mathjs 11.12.0 (15.1.0 is available)
Line 105: + p5 1.11.11 (2.2.0 is available)
Line 106: + react 18.3.1 (19.2.4 is available)
Line 107: + react-chatbot-kit 2.2.2
Line 108: + react-codemirror2 7.3.0 (9.0.1 is available)
Line 109: + react-color 2.19.3
Line 110: + react-confetti 6.4.0
Line 111: + react-countdown 2.3.6
Line 112: + react-dom 18.3.1 (19.2.4 is available)
Line 113: + react-dropzone 14.4.0
Line 114: + react-error-boundary 3.1.4 (6.1.0 is available)
Line 115: + react-helmet 6.1.0
Line 116: + react-hot-toast 2.6.0
Line 117: + react-icons 4.12.0 (5.5.0 is available)
Line 118: + react-infinite-scroll-component 6.1.1
Line 119: + react-infinite-scroll-hook 4.1.1 (6.0.1 is available)
Line 120: + react-infinite-scroller 1.2.6
Line 121: + react-leaflet 4.2.1 (5.0.0 is available)
Line 122: + react-loader-spinner 5.1.5 (8.0.2 is available)
Line 123: + react-organizational-chart 2.2.1
Line 124: + react-p5 1.4.1 deprecated
Line 979: WARNING : Wednesday, Feb 4, 2026: WARNING : Play not found locally : Random Quotes(random-quotes)
Line 980: INFO : Wednesday, Feb 4, 2026: INFO : Checking play locally: Task-Manager(taskmanager)
Line 981: WARNING : Wednesday, Feb 4, 2026: WARNING : Play not found locally : Task-Manager(taskmanager)
Line 982: INFO : Wednesday, Feb 4, 2026: INFO : Checking play locally: ManageTask(managetask)
Line 983: WARNING : Wednesday, Feb 4, 2026: WARNING : Play not found locally : ManageTask(managetask)
Line 984: INFO : Wednesday, Feb 4, 2026: INFO : Checking play locally: 25(25)
Line 985: WARNING : Wednesday, Feb 4, 2026: WARNING : Play not found locally : 25(25)
Line 986: INFO : Wednesday, Feb 4, 2026: INFO : Checking play locally: Soham Bhattacharya(soham-bhattacharya)
Line 987: INFO : Wednesday, Feb 4, 2026: INFO : Play found locally : soham-bhattacharya
Line 988: Creating an optimized production build...
Line 989: Failed during stage 'building site': Build script returned non-zero exit code: 2
Line 990: �[31mFailed to compile.�[39m
Line 991: �[31m�[39m
Line 992: [eslint]
Line 993: src/plays/soham-bhattacharya/SohamBhattacharya.js
Line 994: �[1mLine 49:1:�[22m Delete ··
Line 995: �[1mLine 65:9:�[22m Replace typeof·window·!==·'undefined'·&&·window.CanvasRenderingContext2D·&&·!CanvasRenderingContext2 Line 996: �[1mLine 66:62:�[22m Insert · Line 997: �[1mLine 76:9:�[22m Expected blank line before this statement Line 998: �[1mLine 89:1:�[22m Delete···· Line 999: �[1mLine 93:1:�[22m Delete····`
Line 1000: �[1mLine 112:7:�[22m Expected blank line before this statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants