You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using pnpm to install the application is beneficial if you install often packages or if you have a slow network with other benefits. pnpm store the packages in a folder and use them when needed instead of download them again.
Nevertheless, we have a warning with the current installation regarding eslint :
We need to adjust the dependencies so we can take off this warning.
Before, some people was unable to install with pnpm too because of this problem with eslint.
Updated the dependencies and their peer dependencies to get no more warning
Only package.json and eslintrc.js was changed by my work.
The other files result in the format and lint of the file with the new version of the modules.
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Lint after install the current reactplay.
Update the dependencies and the related peer dependencies
Lint after update.
Add configuration in .eslintrc.js to get warnings instead of errors for unused vars.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
=> the basic lint command.
Checklist:
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
ignore a test created for cypress that will be placed in cypress/e2e, created by create-react-play if #PR46 is validated by no impact on actual app
ignore a file index.json file in the plays folder, created by create-react-play if PR is validated by no impact on actual app ( will be done in some time ).
We should upgrade all the dependencies since a few of them have become deprecated. @Angra974
Updating all the dependencies means to modify codes inside the application ( change between swiper 9 to 10 ).
Some components needs to be lightly modified.
Some dependencies will not be changed because the plays associated with them won't work ( code-editor for exemple ).
I won't be able to test them with Yarn.
Only pnpm and npm as it is use with the workflow here.
For react-p5, it's the author who depreciate the package. No new version for it.
This one is ready.
Deploy is ok.
Less modifications than expected as some are not update to the last version.
Will come later as they needs update in code and will take more time to be validated.
Angra974
changed the title
Update eslint version and configuration for pnpm usage
Update packages version and ready for pnpm
Oct 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using pnpm to install the application is beneficial if you install often packages or if you have a slow network with other benefits. pnpm store the packages in a folder and use them when needed instead of download them again.
Nevertheless, we have a warning with the current installation regarding eslint :
We need to adjust the dependencies so we can take off this warning.
Before, some people was unable to install with pnpm too because of this problem with eslint.
Fixes #1189
Type of change
Updated the dependencies and their peer dependencies to get no more warning
Only package.json and eslintrc.js was changed by my work.
The other files result in the format and lint of the file with the new version of the modules.
Please delete options that are not relevant.
How Has This Been Tested?
Lint after install the current reactplay.
Update the dependencies and the related peer dependencies
Lint after update.
Add configuration in .eslintrc.js to get warnings instead of errors for unused vars.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
=> the basic lint command.
Checklist:
Screenshots or example output
video



Remark: Husky commit use Yarn, so ^^'
Notice :
i've updated the .gitignore file to :