Open
Conversation
Collaborator
|
LEGIT. Obrigado, @arist0tl3! |
Collaborator
|
The style is the "default style" that we use on the examples, right? |
Author
|
I think I understand what you were getting at -- just updated the example to use the default styles and note that |
Collaborator
|
Great. Is there a bug on the styles of the examples? |
Author
|
No, but if I try to do this: the inline style will take precedence. It felt better to suggest removing that inline style and define it instead as a css rule vs keeping it as is and adding |
diasbruno
reviewed
Sep 21, 2022
diasbruno
reviewed
Sep 21, 2022
Co-authored-by: Bruno Dias <dias.h.bruno@gmail.com>
Author
|
Took a stab at wording it; lmk if it does/doesn't make sense lol |
diasbruno
reviewed
Sep 21, 2022
diasbruno
reviewed
Sep 21, 2022
Co-authored-by: Bruno Dias <dias.h.bruno@gmail.com>
Co-authored-by: Bruno Dias <dias.h.bruno@gmail.com>
Collaborator
|
Everything looks good. Thanks so much for taking the time to help with the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an example I used to animate modal content in and apply an opacity transition to the overlay. If this is interesting I can look into adding to the
/examplesas well.Acceptance Checklist:
CONTRIBUTING.md.