Fix High and Medium Level issues #110

Sid2001-maker · 2026-02-02T10:01:35Z

RDKEMW-12252: Coverity Scan Report - Analyzing and Fixing all the Critical and High issues

Reason for change: Resolve Critical and high level issues in coverity
Test Procedure: build should be successful
Risk: low
Priority: P2

Copilot

Pull request overview

This PR addresses Critical and High level issues identified by Coverity scan (RDKEMW-12252). The changes focus on improving error handling, fixing memory leaks, addressing concurrency issues, and correcting format specifiers.

Changes:

Added exception handling with try-catch blocks in main functions across multiple files
Improved error checking for file operations, curl operations, and null pointers
Fixed memory leaks by properly deallocating resources and adding missing delete statements
Enhanced thread safety with atomic counters and improved mutex usage patterns
Corrected format specifiers and log messages to match actual data types

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/jsruntime.cpp	Added exception handling, bounds checking for command-line arguments, and Coverity annotations for tainted data
src/jsc/jsc_lib/jsc_lib.cpp	Fixed exception value conversion, added curl error checking with lambda helper, improved string comparison
src/jsc/JavaScriptUtils.cpp	Improved mutex locking patterns, added file operation error handling, fixed memory leaks in network metrics
src/jsc/JavaScriptEngine.cpp	Corrected format specifier from %d to %f for double variable
src/jsc/JavaScriptContext.cpp	Added memory cleanup for mNetworkMetricsData, added null check for gAAMPJSBindings
src/NativeJSRenderer.cpp	Replaced non-atomic counter with atomic, improved mutex scoping, added curl error checking, fixed log messages
src/JSRuntimeServer.cpp	Initialized res variable to 0 in error case to prevent undefined behavior
src/JSRuntimeClientContainer.cpp	Added exception handling to main function, fixed log format string
src/JSRuntimeClient.cpp	Added predicates to condition_variable wait_for calls, added exception handling to main
include/JSRuntimeClient.h	Added mResponseReceived flag to prevent spurious wakeups in condition_variable
include/IJavaScriptContext.h	Added virtual destructor to polymorphic base class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/NativeJSRenderer.cpp

src/jsc/JavaScriptUtils.cpp

src/jsruntime.cpp

src/jsc/jsc_lib/jsc_lib.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/jsc/JavaScriptUtils.cpp:789

After pushing metricsMap to netMetricsArray at line 788, the metricsMap pointer is not deleted, unlike the pattern seen with headersArray (line 774) and timeMetricsArray (line 786) which are deleted after being pushed. If rtValue does not handle reference counting or take ownership, this could lead to a memory leak. Verify the ownership semantics of rtValue and add appropriate cleanup if needed.

      rtMapObject* metricsMap = new rtMapObject();
      metricsMap->set("url", metrics->url);
      metricsMap->set("method", metrics->method);

      rtArrayObject* headersArray = new rtArrayObject();
      for (const auto& header : metrics->headers) {
        headersArray->pushBack(rtValue(header));
      }
      metricsMap->set("headers", rtValue(headersArray));
      delete headersArray;

      rtArrayObject* timeMetricsArray = new rtArrayObject();
      for (const auto& metric : metrics->timeMetricsData) {
        rtObjectRef timeMetricObj = new rtMapObject();
        timeMetricObj->Set(metric.first.cString(), &metric.second);
        timeMetricsArray->pushBack(rtValue(timeMetricObj));
	delete timeMetricObj;
	timeMetricObj = nullptr;
      }

      metricsMap->set("timeMetricsData", rtValue(timeMetricsArray));
      delete timeMetricsArray;

      netMetricsArray->pushBack(rtValue(metricsMap));
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/NativeJSRenderer.cpp

src/jsc/JavaScriptUtils.cpp

include/JSRuntimeClient.h

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/jsc/JavaScriptUtils.cpp:786

Memory leak: metricsMap is allocated at line 763 but never deleted. After calling pushBack at line 786, the metricsMap object is still owned by the caller and should be deleted to prevent a memory leak. The same pattern used for headersArray and timeMetricsArray should be applied here.

      rtMapObject* metricsMap = new rtMapObject();
      metricsMap->set("url", metrics->url);
      metricsMap->set("method", metrics->method);

      rtArrayObject* headersArray = new rtArrayObject();
      for (const auto& header : metrics->headers) {
        headersArray->pushBack(rtValue(header));
      }
      metricsMap->set("headers", rtValue(headersArray));
      delete headersArray;

      rtArrayObject* timeMetricsArray = new rtArrayObject();
      for (const auto& metric : metrics->timeMetricsData) {
        rtObjectRef timeMetricObj = new rtMapObject();
        timeMetricObj->Set(metric.first.cString(), &metric.second);
        timeMetricsArray->pushBack(rtValue(timeMetricObj));
	delete timeMetricObj;
	timeMetricObj = nullptr;
      }

      metricsMap->set("timeMetricsData", rtValue(timeMetricsArray));
      delete timeMetricsArray;

      netMetricsArray->pushBack(rtValue(metricsMap));

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/jsc/JavaScriptUtils.cpp

src/NativeJSRenderer.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/JSRuntimeServer.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/jsruntime.cpp

src/jsc/jsc_lib/jsc_lib.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T07:39:07Z

src/jsc/JavaScriptUtils.cpp

  if (result)
  {
-      result->setString(buffer);
+      result->setString(buffer.get());


The buffer contains binary data from a WASM file, but setString expects a null-terminated C string. Binary data may contain null bytes in the middle or lack a null terminator, which will cause undefined behavior. Consider using a method that accepts a buffer with explicit size, or ensure proper null termination.

src/jsc/JavaScriptUtils.cpp

src/jsc/jsc_lib/jsc_lib.cpp

src/NativeJSRenderer.cpp

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/jsc/JavaScriptUtils.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-06T09:45:27Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

2 out of 3 committers have signed the CLA.
✅ (Sid2001-maker)[https://github.com/Sid2001-maker]
✅ (vjain008)[https://github.com/vjain008]
❌ @sid-TEL
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

rdkcmf-jenkins · 2026-02-06T09:46:16Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rdkNativeScript/110/rdkcentral/rdkNativeScript
Commit: 72339bc

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T10:08:31Z

src/jsc/JavaScriptUtils.cpp

+
  int size = buf.st_size;

  buffer = (char*)malloc(size);


Missing null check after malloc. The malloc call may return NULL if memory allocation fails, but the code proceeds to use the buffer pointer without checking. This could lead to a null pointer dereference on line 342 if allocation fails. Add a null check after malloc and return RT_ERROR if allocation fails, ensuring proper cleanup of the file pointer.

Copilot · 2026-02-06T10:08:31Z

src/jsc/JavaScriptUtils.cpp

+  size_t bytesRead = fread(buffer, size, 1, ptr);
  fclose(ptr);

+  if (bytesRead != 1)
+  {
+    rtLogError("Failed to read file: expected 1 item, read %zu items", bytesRead);


The fread call expects to read 'size' bytes as a single item, but this is backwards. The correct call should be fread(buffer, 1, size, ptr) to read 'size' items of 1 byte each. The current code reads 1 item of 'size' bytes, which will only succeed if the file size is exactly divisible by 'size' and may not read the entire file content correctly.

Suggested change

size_t bytesRead = fread(buffer, size, 1, ptr);

fclose(ptr);

if (bytesRead != 1)

{

rtLogError("Failed to read file: expected 1 item, read %zu items", bytesRead);

size_t bytesRead = fread(buffer, 1, size, ptr);

fclose(ptr);

if (bytesRead != static_cast<size_t>(size))

{

rtLogError("Failed to read file: expected %d bytes, read %zu bytes", size, bytesRead);

Copilot · 2026-02-06T10:08:31Z

src/jsc/JavaScriptUtils.cpp

+  if (bytesRead != 1)
+  {
+    rtLogError("Failed to read file: expected 1 item, read %zu items", bytesRead);
+    free(buffer);
+    return RT_ERROR;
+  }


The validation check is incorrect following the fread parameter correction. If fread(buffer, 1, size, ptr) is used as it should be, the success condition should check if bytesRead equals 'size', not 1. The current check for bytesRead != 1 would be incorrect after fixing the fread parameters.

Copilot · 2026-02-06T10:08:32Z

src/jsruntime.cpp

@@ -57,7 +58,9 @@ int main(int argc, char* argv[])
        {
            appendindex = i-1;
 	    i++;
-            waylanddisplay = argv[i];
+            if (i < argc) {
+                waylanddisplay = argv[i];
+            }
        }
 	else if (strcmp(argv[i], "--enableHttp") == 0)
        {
@@ -107,16 +110,11 @@ int main(int argc, char* argv[])
        }
 	i++;
    }
-
+    
    std::shared_ptr<NativeJSRenderer> renderer = std::make_shared<NativeJSRenderer>(waylanddisplay);
    if (consoleMode) {
        renderer->setEnvForConsoleMode(moduleSettings);
    }
-    if (!renderer)
-    {
-        NativeJSLogger::log(ERROR, "Unable to run application\n");
-        return -1;
-    }

 #if defined(ENABLE_JSRUNTIME_SERVER)
    if (runServer == true)
@@ -172,6 +170,13 @@ int main(int argc, char* argv[])
    }

    return 0;


The try block starting on line 40 is not properly indented. All code inside the try block should be indented consistently. Currently, the code starting from line 41 onwards has inconsistent indentation, making the code structure unclear.

Copilot · 2026-02-06T10:08:32Z

src/NativeJSRenderer.cpp

 	else
 	{
-		NativeJSLogger::log(ERROR, "Unable to find application with id: %d and url: %s\n", id, mContextMap[id].url);
+		NativeJSLogger::log(ERROR, "Unable to find application with id: %d and url: %s\n", id, mContextMap[id].url.c_str());


Potential undefined behavior: accessing mContextMap[id].url when id is not in the map. The else branch at line 445 is executed when the id is not found in mContextMap (line 433), but line 447 tries to access mContextMap[id].url, which will create a new entry with default values if the id doesn't exist. This could lead to accessing uninitialized data or creating phantom entries. The error message should either not include the URL or store it before checking if the id exists.

Copilot · 2026-02-06T10:08:32Z

src/jsc/JavaScriptUtils.cpp

  rtValue keys;
  if (map->Get("allKeys", &keys) != RT_OK) {
    rtLogWarn("Could not retrieve url for network metrics data.");
+    delete netMetricsArray; //newly added


The inline comment "newly added" is unnecessary and should be removed. Such comments don't add value to the code and become outdated over time. The version control system already tracks what was added and when.

Copilot · 2026-02-06T10:08:32Z

src/jsc/JavaScriptUtils.cpp


  if (!keysArray) {
    rtLogWarn("No url found in the network metrics data.");
+    delete netMetricsArray; //newly added


The inline comment "newly added" is unnecessary and should be removed. Such comments don't add value to the code and become outdated over time. The version control system already tracks what was added and when.

Copilot · 2026-02-06T10:08:33Z

src/jsc/JavaScriptContext.cpp

    }
    mPriv->releaseAllProtected();
+
+    //changed added


The inline comment "changed added" is unclear and should be removed. Such comments don't add value to the code and become outdated over time. The version control system already tracks what was added and when.

Suggested change

//changed added

Copilot · 2026-02-06T10:08:33Z

src/jsc/JavaScriptUtils.cpp

+  if (stat(fd, &buf) != 0)
+  {
+    rtLogError("Failed to stat file: %s", fd);
+    fclose(ptr);
+    return RT_ERROR;
+  }


Attempting to close a potentially null file pointer. The fopen call on line 327 may return NULL if the file cannot be opened, but the code proceeds to call fclose(ptr) without checking if ptr is null. This will cause undefined behavior if the file doesn't exist or can't be opened. Add a null check after fopen and return an error if the file couldn't be opened.

Copilot · 2026-02-06T10:08:33Z

src/jsc/JavaScriptUtils.cpp

      NetworkMetrics* metrics = (NetworkMetrics*)storedValue.toVoidPtr();
      if (!metrics) {
        rtLogError("Failed to cast stored value to NetworkMetrics structure for url: %s.", key.cString());
+        delete netMetricsArray; //newly added


The inline comment "newly added" is unnecessary and should be removed. Such comments don't add value to the code and become outdated over time. The version control system already tracks what was added and when.

Suggested change

delete netMetricsArray; //newly added

delete netMetricsArray;

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T10:24:29Z

src/jsc/JavaScriptUtils.cpp

+
+  if (!ptr)
+  {
+    rtLogError("Failed to open file: hello.wasm");
+    return RT_ERROR;
+  }

  const char *fd = "hello.wasm";
  struct stat buf;

-  stat(fd, &buf);
-  int size = buf.st_size;
+  if (stat(fd, &buf) != 0)


The file pointer 'ptr' could be NULL if fopen fails. The code checks stat() result but calls fclose(ptr) without checking if ptr is NULL. This will cause undefined behavior if the file cannot be opened. Add a NULL check for ptr before attempting to close it, or better yet, check if ptr is NULL immediately after fopen and handle the error appropriately.

Copilot · 2026-02-06T10:24:29Z

src/jsc/JavaScriptUtils.cpp

+    return RT_ERROR;
+  }
+


There is a resource leak if malloc fails. When buffer allocation fails, the function continues to call fread without checking if buffer is NULL, and ptr remains open without being closed. Add a NULL check after malloc and properly handle the error by closing ptr and returning an error.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/NativeJSRenderer.cpp:480

NativeJSRenderer::run() holds mUserMutex while dispatching each pending request. The called handlers (e.g., runApplicationInternal() -> network downloadFile() + runScript() / runFile()) can be long-running, which blocks producers that need mUserMutex (create/run/terminate requests) and increases deadlock risk if any callback path tries to acquire the same mutex. Consider swapping gPendingRequests into a local vector under the lock, unlocking, and then processing requests without holding mUserMutex, only re-locking around minimal shared-state updates (e.g., mContextMap).

	mUserMutex.lock();
        for (int i=0; i<gPendingRequests.size(); i++)
        {

            ApplicationRequest& request = gPendingRequests[i];

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-11T13:40:09Z

include/JSRuntimeClient.h

        if (derived.send(command))
        {
            std::unique_lock<std::mutex> lock(mResponseMutex);
-            mResponseCondition.wait_for(lock, std::chrono::seconds(5));
-            response = mLastResponse;
-            return true;
+            mResponseReceived = false;
+            bool gotResponse = mResponseCondition.wait_for(lock, std::chrono::seconds(5), 


In CommandInterface::sendCommand(), derived.send(command) happens before mResponseReceived is reset under mResponseMutex. If a response arrives quickly, onMessage() can set mResponseReceived=true and notify before sendCommand() takes the lock, and then sendCommand() overwrites the flag back to false and waits the full timeout (missed wakeup). Reset the flag (or increment a sequence counter) while holding mResponseMutex before sending, and consider clearing/consuming mLastResponse in the same critical section.

Copilot · 2026-02-11T13:40:09Z

src/NativeJSRenderer.cpp

-        bool ret = mConsoleState->consoleContext->runScript(mConsoleState->codeToExecute.front().c_str(), false);
+    // Process items from local queue (no race condition)
+    for (const auto& code : localQueue) {
+        bool ret = mConsoleState->consoleContext->runScript(code.c_str(), false);


processDevConsoleRequests() assigns the return value of runScript() to ret, but ret is never used. This will trigger an unused-variable warning (and may fail builds if warnings are treated as errors). Either remove ret or use it (e.g., log/report execution failures).

Suggested change

bool ret = mConsoleState->consoleContext->runScript(code.c_str(), false);

mConsoleState->consoleContext->runScript(code.c_str(), false);

Copilot · 2026-02-11T13:40:10Z

src/jsruntime.cpp

+                NativeJSLogger::log(INFO, "Received display argument: '%s'\n", argv[i]);
+                std::string sanitizedDisplay;
+                if (!sanitizeDisplayName(argv[i], sanitizedDisplay)) {
+                    NativeJSLogger::log(WARN, "Invalid display name '%s'. Must be 1-64 characters containing only alphanumeric, hyphens, underscores, and dots\n", argv[i]);


The --display value is logged verbatim before validation/sanitization. Since this comes from argv, it can contain control characters/newlines and lead to log injection or confusing logs. Prefer logging only the sanitized value, or escape/quote non-printable characters when logging rejected input.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sid2001-maker requested a review from a team as a code owner February 2, 2026 10:01

Copilot AI review requested due to automatic review settings February 2, 2026 10:01

Copilot started reviewing on behalf of Sid2001-maker February 2, 2026 10:01 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

src/NativeJSRenderer.cpp Outdated Show resolved Hide resolved

src/jsc/JavaScriptUtils.cpp Show resolved Hide resolved

src/jsruntime.cpp Show resolved Hide resolved

src/jsc/jsc_lib/jsc_lib.cpp Outdated Show resolved Hide resolved

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from d8e9c66 to aa1d794 Compare February 2, 2026 10:53

Sid2001-maker requested a review from Copilot February 2, 2026 10:55

Copilot started reviewing on behalf of Sid2001-maker February 2, 2026 10:55 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

src/NativeJSRenderer.cpp Show resolved Hide resolved

src/jsc/JavaScriptUtils.cpp Outdated Show resolved Hide resolved

include/JSRuntimeClient.h Outdated Show resolved Hide resolved

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from aa1d794 to 3d0c78b Compare February 2, 2026 11:58

Sid2001-maker requested a review from Copilot February 2, 2026 12:00

Copilot started reviewing on behalf of Sid2001-maker February 2, 2026 12:00 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

src/jsc/JavaScriptUtils.cpp Outdated Show resolved Hide resolved

src/NativeJSRenderer.cpp Outdated Show resolved Hide resolved

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from 3d0c78b to c88081b Compare February 2, 2026 12:25

Sid2001-maker requested a review from Copilot February 2, 2026 13:33

Copilot started reviewing on behalf of Sid2001-maker February 2, 2026 13:34 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

src/JSRuntimeServer.cpp Outdated Show resolved Hide resolved

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from c88081b to bde12cf Compare February 3, 2026 07:00

Sid2001-maker requested a review from Copilot February 3, 2026 07:03

Copilot started reviewing on behalf of Sid2001-maker February 3, 2026 07:03 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

src/jsruntime.cpp Outdated Show resolved Hide resolved

src/jsc/jsc_lib/jsc_lib.cpp Show resolved Hide resolved

Sid2001-maker requested a review from Copilot February 3, 2026 07:34

Copilot started reviewing on behalf of Sid2001-maker February 3, 2026 07:34 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 3, 2026 09:49

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 3, 2026 11:31

Copilot started reviewing on behalf of Sid2001-maker February 3, 2026 11:31 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 3, 2026 12:15

Copilot started reviewing on behalf of Sid2001-maker February 3, 2026 12:15 View session

Copilot started reviewing on behalf of Sid2001-maker February 5, 2026 10:04 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

src/jsc/JavaScriptUtils.cpp Show resolved Hide resolved

vjain008 requested a review from Copilot February 5, 2026 13:33

Copilot started reviewing on behalf of vjain008 February 5, 2026 13:33 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from c744166 to 72339bc Compare February 6, 2026 09:45

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from 72339bc to eea14a4 Compare February 6, 2026 10:03

Copilot AI review requested due to automatic review settings February 6, 2026 10:03

Copilot started reviewing on behalf of Sid2001-maker February 6, 2026 10:03 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 6, 2026 10:19

Copilot started reviewing on behalf of Sid2001-maker February 6, 2026 10:19 View session

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from eea14a4 to c744166 Compare February 6, 2026 10:23

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 6, 2026 10:25

Copilot started reviewing on behalf of Sid2001-maker February 6, 2026 10:25 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Sid2001-maker requested a review from Copilot February 11, 2026 13:35

Copilot started reviewing on behalf of Sid2001-maker February 11, 2026 13:35 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Fixing the Coverity Issue CID:430751

4de5f6f

Sid2001-maker force-pushed the topic/RDKEMW-12252 branch from c2a8496 to 4de5f6f Compare February 11, 2026 13:43

Sid2001-maker requested a review from Copilot February 11, 2026 13:43

Copilot started reviewing on behalf of Sid2001-maker February 11, 2026 13:44 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

vjain008 approved these changes Feb 11, 2026

View reviewed changes

vjain008 merged commit 55b7b45 into develop Feb 11, 2026
12 of 14 checks passed

github-actions bot locked and limited conversation to collaborators Feb 11, 2026

	delete netMetricsArray; //newly added
	delete netMetricsArray;

	bool ret = mConsoleState->consoleContext->runScript(code.c_str(), false);
	mConsoleState->consoleContext->runScript(code.c_str(), false);

Fix High and Medium Level issues #110

Fix High and Medium Level issues #110

Uh oh!

Conversation

Sid2001-maker commented Feb 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2026 •

edited

Loading