feat: export Products page as a component and consume it in apps/admin#1363
Open
paanSinghCoder wants to merge 7 commits intofeat/export-invoices-pagefrom
Open
feat: export Products page as a component and consume it in apps/admin#1363paanSinghCoder wants to merge 7 commits intofeat/export-invoices-pagefrom
paanSinghCoder wants to merge 7 commits intofeat/export-invoices-pagefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 21629945937Details
💛 - Coveralls |
…I to use new views structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move products page to
@raystack/frontier/adminSummary
Moved the products UI from
apps/admin/src/containers/products.list/intoweb/lib/admin/pages/products/as router-agnostic pages. The admin app wires routing via thin wrappers and callbacks.Changes
Lib
web/lib/admin/pages/products/—index.tsx,details.tsx,header.tsx,columns.tsx,products.module.css,types.tsx.web/lib/admin/pages/products/prices/—index.tsx,columns.tsx.@raystack/frontier/admin:ProductsPage— optional props:selectedProductId,onSelectProduct,onCloseDetail,onNavigateToPrices,appName.ProductPricesPage— optional props:productId,appName,onBreadcrumbClick.onNavigateToPrices,onBreadcrumbClick) so the lib stays router-agnostic.App
ProductsPageWithRouter— usesuseParams/useNavigate, passesonSelectProduct,onCloseDetail,onNavigateToPrices.ProductPricesPageWithRouter— usesuseParams/useNavigate, passesonBreadcrumbClickfor breadcrumb navigation.products→ product list (with optional detail sheet).products/:productId→ product list with detail forproductId.products/:productId/prices→ product prices.containers/products.list; products UI now lives in the lib.Note
To test locally, set the frontier dependency to the workspace package in
frontier/web/apps/admin/package.json:Technical details
Test plan