Support complex context in Duktape by using eval#46
Support complex context in Duktape by using eval#46maisumakun wants to merge 1 commit intorails:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@rafaelfranca Any progress on this? |
|
It is missing tests, so it is hard to assert it is actually doing what it should |
|
I opened #76 to start a proper discussion around how to handle this issue |
Just like
ExecJS::ExternalRuntime::Context#call, not using Duktape's#call_propbut simpleevalwill solve #45 .I don't know if there might be any side effects for this change, but it seems working.