feat: add storage deletion workflow with conditional execution#1492
Draft
feat: add storage deletion workflow with conditional execution#1492
Conversation
achatur
force-pushed
the
add_deletes_for_storage
branch
2 times, most recently
from
114b1eb to
99b71d8
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
from
7630230 to
26c6206
Compare
cardoe
force-pushed
the
add_deletes_for_storage
branch
from
5a37de0 to
9625024
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
from
9625024 to
80d9de6
Compare
cardoe
reviewed
Feb 4, 2026
| triggers the ansible playbook without requiring a Python handler. | ||
|
|
||
| The sensor extracts the following parameters from the event: | ||
| - device_id: from payload.node (the Ironic node UUID) |
Contributor
There was a problem hiding this comment.
This is the nova instance UUID and not the Ironic node which might matter here?
achatur
force-pushed
the
add_deletes_for_storage
branch
from
80d9de6 to
5ed8396
Compare
cardoe
reviewed
Feb 4, 2026
| exchangeName: nova | ||
| exchangeType: topic | ||
| exchangeDeclare: | ||
| durable: false |
Contributor
There was a problem hiding this comment.
Suggested change
| durable: false | |
| durable: true |
achatur
force-pushed
the
add_deletes_for_storage
branch
from
5ed8396 to
c70e6d2
Compare
Add storage cleanup steps to keystone oslo event sensor with proper conditional execution based on event type. Centralize deletion logic in openstack-oslo-event workflow template output parameters. - Add ansible-delete-server step triggered by server_storage_delete - Pass node_uuid as device_id to server deletion playbook - Added oslo sensor for nova for delete - Added handler and registered it
Replace Python handler with direct sensor filtering for Nova instance delete events. This simplifies the workflow by using Argo Events data filters to check if storage cleanup is needed. Changes: - Add data filter to check metadata.storage == 'wanted' in sensor - Extract device_id and project_id directly from event payload - Remove Python handler step and UUID conversion - Trigger storage_on_server_delete.yml ansible playbook directly - Deprecate handle_instance_delete() Python function - Set check_mode to false for actual execution Benefits: - Simpler workflow with fewer steps - Faster execution without Python handler overhead - Easier to understand and maintain - Follows event-driven architecture patterns
achatur
force-pushed
the
add_deletes_for_storage
branch
from
c70e6d2 to
e198817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add storage cleanup steps to keystone oslo event sensor with proper conditional execution based on event type. Centralize deletion logic in openstack-oslo-event workflow template output parameters.