Open
Conversation
…hat). Also fix some message formatting.
…s that appear to be causing an issue.
…his now. It's more broken than when I started.
…fix) nickname checking. Adjust rule parameter order to allow full collection of the reason.
4 tasks
Member
|
I think these cogs should be combined into one cog. Multiple command groups, sure. |
issy
requested changes
May 29, 2023
Member
issy
left a comment
issy
left a comment
There was a problem hiding this comment.
Overall implementation looks good - just some comments around ergonomics and such. I think ideally I would like to see config and caches as wrapper classes with defined methods. This makes it much clearer how this thing is intended to be used, as we may expand on this later. With the size of this cog, I think that makes a lot of sense. Let me know what you think. Happy to help with any implementation details. Thank you for fleshing this feature out.
…stantial changes to alerting and command processing (no logic changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial Checklist
Details
Does this resolve an issue?
Resolves #220
Changes
Features / Fixes
Breaking Changes
Additional
All have been tested and are working. The config defaults are crazy and will need to be tuned to established numbers following installation.