Open
Conversation
Contributor
Author
|
I also added some fixes for Visual Studio. It was actually working here, but Visual Studio doesn't save everything when Hit Ctrl +S or closing the app. Now its fixed. |
Contributor
Author
|
Actually wait to merge, the paths are not in Release mode. |
Member
|
Sorry I haven't had much time to review this. Looks like you're making good progress. One thing I'd be curious to see is if we could generate VS stuff with Aside from that, I think I'd be hesitant to apply DLL_EXPORT like this everywhere, but I know that I also need to add extern C everywhere. I'll see if I can think of a way that does both in the right situations. |
Fixed Conflicts
Correct a spelling mistake.
1. In the Debug build, remove -march=native. Some toolchains may not support this option and it is not necessary. 2. Specify C as the project language since there is no C++ code. This allows toolchains lacking C++ support to build the library. 3. Switch check_cxx_source_compiles to check_c_source_compiles, also for removing dependency on C++. Signed-off-by: Joel Carlson <JoelsonCarl@gmail.com>
CMakeLists.txt: fixes for various toolchains
On a machine without SSE4.1 the HAVE_SSE flag would still be set. Because CFLAGS is set to include -msse4.2, the compiler happily generates SSE 4.2 instructions. Running any resulting SSE-enabled binary would then result in an illegal instruction error. The HAVE_SSE check now checks for the presence of one of the SSE 4.1 instructions that is used in the SSE enabled convolutional decoder. The check must run with -march=native to ensure it checks against the host machine capabilities. The HAVE_SSE definition is now propagated to downstream targets that depend on libcorrect. This means they can now ifdef on HAVE_SSE to decide whether or not to include libcorrect's SSE specific header. Confirmed that the HAVE_SSE check now fails on an old machine without SSE 4.1 (but with SSE 3 and SSSE 3).
Fixes for SSE detection and propagation
-Wpedantic is only provided by gcc >= 4.8. Since showing pedantic warnings is not really mandatory, let's only use this option when the compiler supports it. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
CMakeLists.txt: conditionally use -Wpedantic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the CPACK stuff for generating debian packages just by using
make packageinside build folder. Libcorrect is a dependency of my libSatHelper on https://github.com/opensatelliteproject so it would be usefull to have a package generator on the github repository :D