Add codespell support (config, workflow to detect/not fix) and make it fix few typos#576
Open
yarikoptic wants to merge 4 commits intoquarto-dev:mainfrom
Open
Add codespell support (config, workflow to detect/not fix) and make it fix few typos#576yarikoptic wants to merge 4 commits intoquarto-dev:mainfrom
yarikoptic wants to merge 4 commits intoquarto-dev:mainfrom
Conversation
Contributor
|
Thanks for the PR and the typo fixes. I'm reluctant to take in a dependency of a tool no one in our team uses (if we did, it would be supported here already), especially when there's CI consequences that will affect our workflow and we have no experience with them. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…agically
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
5266c14 to
a95dba1
Compare
Author
|
Hi @cscheid the decision is yours to make -- I can only humbly contribute ;) FWIW - disabling github workflow is easy -- just remove it ;) maintenance should be minimal if any. Meanwhile -- rebased, and redid fixing to address conflicts. Please advise -- I could drop tooling and just leave config (so later runs would not suffer false positives etc) + fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.