add a note on extracting multiline processing in comprehensions#148
Open
graingert wants to merge 2 commits intoquantifiedcode:masterfrom
Open
add a note on extracting multiline processing in comprehensions#148graingert wants to merge 2 commits intoquantifiedcode:masterfrom
graingert wants to merge 2 commits intoquantifiedcode:masterfrom
Conversation
graingert
commented
Feb 28, 2020
docs/readability/using_map_or_filter_where_list_comprehension_is_possible.rst
Outdated
Show resolved
Hide resolved
graingert
commented
Feb 28, 2020
| def cond(v): ... | ||
|
|
||
| [process(x) for x in items if cond(v)] # preferable to map(process, filter(cond, items)) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
how about also a note on how to combine cond and process?
Sometimes a condition or process may repeat computation unnecessarily, in those cases extract a function that returns an iterable with the result or an empty iterable:
.. code:: python
hams = [x["ham"] for x in items if "ham" in x] # duplicate key lookup
.. code:: python
def process(x):
try:
return (x["ham"],)
except KeyError:
return ()
hams = [ham for x in items for ham in process(x)]
Contributor
Author
There was a problem hiding this comment.
It's also often possible to inline this empty iterable into the comprehension
.. code:: python
hams = [x["ham"] for x in items if x.get("ham") is not None] # duplicated key lookup
.. code:: python
hams = [
ham
for x in items
for ham in (x.get("ham"),)
if ham is not None
]
and alternative in python 3.8+ is
.. code:: python
hams = [
ham
for x in items
if (ham := x.get("ham")) is not None
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #135