Conversation
…responding uv pixel, rather than a different position per pixel
…is helps generated points better match the surface of the geometry -- without they might appear slightly above or slightly below the surface.
…le instead of detail wrangle.)
Contributor
|
Thanks @JosephSilvermanArt this is great, I'll check it out soon! One question -- I see on your screenshots that you're using a non-commercial edition, did you save over the otls in non-commercial? That might affect things |
Author
|
@johnnyquest Ah, yep, that totally slipped my mind. I'll make a new commit from my work computer later today. |
Author
|
Should be all set now! |
Contributor
|
Cool thanks, I'll check it out soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made two edits to the uvpointcloud sop that i believe are bug fixes --
Before and after of the grid change below, pictured with 128x128, with a tiling texture showing one square per pixel. Note that in the before, points start in one corner at 0.0, 0.0 in uv space, and gradually drift as they approach the center. In the after, points are always at the center of each pixel.
I didn't capture a screenshot of the divide change, but the issue it fixes is clearly visible in the screenshots around the center left (5, f, g, 6, 7, g) where that quad's points all were offset slightly behind the mesh.
before
after
(ps: qlib is super useful to me, thanks a ton for creating and maintaining it)