-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-129401: Test repr rlock failing randomly #129959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-129401: Test repr rlock failing randomly #129959
Conversation
Misc/NEWS.d/next/Tests/2025-02-10-14-34-29.gh-issue-129401.Cq6Ruy.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Gross <colesbury@gmail.com>
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit a801408 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F129959%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
colesbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @colesbury , I think we may need to backport this fix to 3.13, see #144381 (comment) Also, we should add a cpython/Lib/test/_test_multiprocessing.py Lines 1538 to 1545 in a447828
What do you think? If that’s the right approach, I’d be happy to submit a PR. |
|
Thanks @YvesDup for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Fix and simplify a test of `test_repr_rlock` about multiprocessing.RLock primitive. (cherry picked from commit a98a6bd) Co-authored-by: Duprat <yduprat@gmail.com>
|
GH-144405 is a backport of this pull request to the 3.13 branch. |
Yeah, that sounds right to me. Please open a PR |
Fix and simplify a test of
test_repr_rlockabout multiprocessing.RLock primitive.I am wondering if this fix must not be apply to the identical test of primitive multiprocessing.Lock (in
test_repr_lock).test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlockis flaky #128206test_repr_rlockfailing randomly on main branch CI #129401