Fix icon when passing Marker to GeoJson#2086
Fix icon when passing Marker to GeoJson#2086hansthen merged 4 commits intopython-visualization:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
folium/map.py
Outdated
| draggable=draggable or None, autoPan=draggable or None, **kwargs | ||
| ) | ||
| # this attribute is not used by Marker, but by GeoJson | ||
| self.icon: Optional[Icon] = None |
There was a problem hiding this comment.
This still fails if people use the add_child method to add an icon. I am okay with that, but I think we should be aware of it.
There was a problem hiding this comment.
Also the render method (roughly lines 430-436) was originally rewritten to allow people to use add_child. If we go back to icon as a member variable, we should make it consistent throughout the class.
|
Is this waiting for some changes or are we fine with it as is? I am unable to properly see the consequences here so will let you be the judges but I'd love this to be merged to fix geopandas CI. |
Ah, sorry it escaped my attention. Will look at it presently. |
hansthen
force-pushed
the
fix-geojson-marker-icon
branch
3 times, most recently
from
ee52330 to
df180b3
Compare
3 participants
Fixes #2084, which is an issue introduced by #2068.
We shouldn't have removed
self.iconinMarker. It's not directly visible where it is used, so I added a comment to prevent this from happening again.