Conversation
Contributor
Author
|
Tweaked further for Chrome on Android. It needs testing on iPad as well. Somewhat smaller fonts helps on phones. The print output changes should be kept even if we abandon the rest of the twiddles. |
added 3 commits
May 18, 2022 11:24
…retrieve it; cleaner handling of print-only/screen-only
bmaranville
reviewed
May 19, 2022
|
|
||
| <div class="screen-only"> | ||
| <?php | ||
| include("/var/www/include/navigation.inc"); |
Contributor
There was a problem hiding this comment.
These includes are likely to be abandoned in the future.
Contributor
Author
|
Tested on Windows (Edge, IE), IPad, iPhone SE, Android (Firefox, Chrome), Mac (Firefox, Chrome, Safari) and Linux (Firefox, Chrome), including printing on desktop browsers. Some layout is not ideal (slightly overlapping boxes) and the iPhone results font is too large, but nothing too outlandish. I'm inclined to merge. |
Contributor
Author
|
Most of these changes have been pulled into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to improve the mobile experience by tweaking CSS settings and scrolling to output on calculate.
Developed using Chrome, Safari and Firefox reactive mode, with various device form factors.
Tested on iPhone SE Safari, Android MotoG7 Firefox.
This needs testing on more devices before pushing.