Fix Ascii IFD reading as TIFF6.0 spec#1451
Open
TheZ3ro wants to merge 1 commit intopython-openxml:masterfrom
Open
Fix Ascii IFD reading as TIFF6.0 spec#1451TheZ3ro wants to merge 1 commit intopython-openxml:masterfrom
TheZ3ro wants to merge 1 commit intopython-openxml:masterfrom
Conversation
Open
Author
|
@scanny can you kindly merge this? Thanks! |
Author
|
any news on this? @scanny |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #187
The TIFF6 specification writes:
python-docx by default uses the Value/Offset field as a offset for ASCII IFD, but sometime the Value/Offset field could contain directly the Value (if it contains a string with 4 or less characters including the final NULL byte/string terminator)
This is the case for the 2 pictures linked in issue #187 (the

SoftwareASCII field contains8.3)