This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Edge Build with --noconsole Crash Fix#626
Open
doug-benn wants to merge 2 commits intopython-eel:mainfrom
Open
Conversation
samuelhwilliams
force-pushed
the
edge-bug-fix
branch
from
fade881 to
68ab7a3
Compare
Contributor
Author
|
I'll be honest I don't know what has gone on here, hope I didn't break it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug when building for edge, it will crash if the --noconsole arg is used.
This should fix it