Add ab09hd and tg01gd, and show that n,m,p can be removed#225
Open
mccullerlp wants to merge 15 commits intopython-control:masterfrom
Open
Add ab09hd and tg01gd, and show that n,m,p can be removed#225mccullerlp wants to merge 15 commits intopython-control:masterfrom
mccullerlp wants to merge 15 commits intopython-control:masterfrom
Conversation
Collaborator
|
Thank you very much for your enthusiasm and work on Slycot.
|
bnavigator
reviewed
Jan 8, 2024
| .coverage | ||
| *~ | ||
| .#* | ||
| .*~ |
Collaborator
There was a problem hiding this comment.
.*~ This is already covered by *~
What kind of tool creates files with # in it?
bnavigator
reviewed
Jan 8, 2024
Comment on lines
+1469
to
+1472
| A[..., :nr, :nr], | ||
| E[..., :nr, :nr], | ||
| B[..., :nr, :], | ||
| C[..., :, :nr], |
Collaborator
There was a problem hiding this comment.
Remove the leading ... parts. The wrapper only returns two-dimensional arrays.
Collaborator
|
Hi @mccullerlp, glad to see you working on this branch. My comments from December 2023 are still valid. Please make a rebase. There are lots of changes listed in this PR diff that are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I wanted to test using ab09hd as it can ensure relative error during reduction. Additionally, tg01gd is useful for maintaining descriptor systems and reducing them back to a standard form. I've added wrappers and python interfaces. It's less work if you are willing to pull directly, but I could split this into separate PR's. The docstrings are possibly too much of a copy of the slicot documentation?
Additionally, I added an auxiliary wrapper for ab09nd that adjusts the dependency resolution between n,m,p and a,b,c. This is a general technique that can allow the n,m,p arguments to be dropped from any/all of the wrappers. I know this changes the interface, since n,m,p are exposed to the external API, even though they could all be determined from the python-side wrappers anyway. Including it since I already tested it, and it may be of some interest to simplify the interfaces.